Simplify Housekeeping Process for DAGMC#943
Conversation
|
perhaps we should update these two files to match what clang-format is generating as part of this PR so that it passes tests |
gonuke
left a comment
There was a problem hiding this comment.
This looks good - I thought I had done this already :) but maybe it's lost in my local branches somewhere.
We can perhaps take care of the two formatting inconsistencies in the current code that are causing this to fail right now. I wonder if they are due to slight changes in clang-format's behavior since the docker images was generated.
gonuke
left a comment
There was a problem hiding this comment.
Thanks for streaming in this @ahnaf-tahmid-chowdhury
|
This now has a conflict in the |
|
It looks like there is an update in CMake version in the new Windows runner... I'm not sure yet if/why that is causing a problem. |
|
We may need to provide more information to our CMake config for MOAB. It may be true that MOAB should improve their custom |
gonuke
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up @ahnaf-tahmid-chowdhury
Description
This PR simplifies the housekeeping process for DAGMC by removing the dependency on a Docker container and installing
clang-formatdirectly through the workflow.Related Issues
Housekeeping of DAGMC is very complicated now. And it seems in the docker file, we are just installing clang-format through apt. Also, I noticed the docker publish file is changed and there is no way to rebuild a new docker image for housekeeping.
Changes
clang-formatdirectly through the workflow.