Remove spaces from image name#948
Closed
gonuke wants to merge 2 commits into
Closed
Conversation
Member
|
Ops! Sorry. I have forgotten to resolve that one. |
ahnaf-tahmid-chowdhury
left a comment
Member
There was a problem hiding this comment.
I believe that by approaching the problem in this manner, the issue with spaces can be resolved.
| -moab_${{ inputs.moab_version }} | ||
| -geant4_${{ inputs.geant4_version }} | ||
| -double_down_${{ inputs.double_down_version }} | ||
| ghcr.io/${{ github.repository_owner }}/dagmc-ci-ubuntu-${{ inputs.ubuntu_version }}-${{ inputs.compiler}}-hdf5_${{ inputs.hdf5_version}}-moab_${{ inputs.moab_version }}-geant4_${{ inputs.geant4_version }}-double_down_${{ inputs.double_down_version }} |
There was a problem hiding this comment.
Suggested change
| ghcr.io/${{ github.repository_owner }}/dagmc-ci-ubuntu-${{ inputs.ubuntu_version }}-${{ inputs.compiler}}-hdf5_${{ inputs.hdf5_version}}-moab_${{ inputs.moab_version }}-geant4_${{ inputs.geant4_version }}-double_down_${{ inputs.double_down_version }} | |
| ghcr.io/${{ github.repository_owner | |
| }}/dagmc-ci-ubuntu-${{ inputs.ubuntu_version | |
| }}-${{ inputs.compiler | |
| }}-hdf5_${{ inputs.hdf5_version | |
| }}-moab_${{ inputs.moab_version | |
| }}-geant4_${{ inputs.geant4_version | |
| }}-double_down_${{ inputs.double_down_version | |
| }} |
There was a problem hiding this comment.
However, we need to give this a test run, don't know if the action actually works in this way.
There was a problem hiding this comment.
Or, I think we may proceed with the following code that we already used in our docker_publish.yml:
- name: Configure docker image tag
run: |
image_base_tag=ghcr.io/${{ github.repository_owner }}/
image_base_tag+=dagmc-ci-ubuntu-${{ matrix.ubuntu_version }}
image_base_tag+=-${{ matrix.compiler}}
image_base_tag+=-hdf5_${{ matrix.hdf5_version}}
image_base_tag+=-moab_${{ matrix.moab_version }}
image_base_tag+=-geant4_${{ matrix.geant4_version }}
image_base_tag+=-double_down_${{ matrix.double_down_version }}
echo "image_base_tag=${image_base_tag}" >> "$GITHUB_ENV"
Member
Author
There was a problem hiding this comment.
If you make a PR with this update, I'll withdraw mine and review yours.
There was a problem hiding this comment.
PR #949 fixed the incorrect and introduced illegal spaces in the action.yml file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes extra spaces from the image used for advisory testing
Motivation and Context
Reformatting of GitHub action was incorrect and introduced illegal spaces.