Non-empty stderr for go list is not an error in itself
#1981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
The current implementation of getting a list of packages (
listPackages) assumes that a non-empty stderr in the output ofgo listis an error, regardless of the result of the call, which is not true. Here is an example of a non-empty stderr:There is no information on errors. This is a legitimate output of additional information.
As a result, we get a non-zero status code without any reason.
Let's rely on the error return, and only add the contents of stderr along with it (preferably removing all lines with
go: downloading).