Skip to content

Missing call to setgroups before setuid in sway/main.c #884

Description

@Fale

In https://github.com/SirCmpwn/sway/blob/master/sway/main.c#L159 there is a call to setgroups before setuids.
There is a high probability this means it didn't relinquish all groups, and this would be a potential security issue to be fixed.
See https://www.securecoding.cert.org/confluence/display/c/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions