Skip to content

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 18, 2020

cc @Brooooooklyn
Because definitions of ast nodes change over time, I think this is the easiest way for end-users.
(TypeScript introduces new feature, ecmascript spec evolves)


Closes #1048.

@kdy1 kdy1 added this to the v1.2.29 milestone Sep 18, 2020
@Brooooooklyn
Copy link
Member

Just a note, ts-jest has added path-mapping transformer plugin for jest users: https://github.com/kulshekhar/ts-jest/blob/master/src/transformers/path-mapping.ts.
We should also implement it if { hidden: { jest: true } }.

@kdy1 kdy1 assigned kdy1 and unassigned kdy1 Sep 18, 2020
@kdy1 kdy1 self-assigned this Sep 18, 2020
@kdy1
Copy link
Member Author

kdy1 commented Sep 18, 2020

I looked at it, but it seems like cjson parser is required.
I'll make @swc/jest faster alternative for babel-jest and improve it over time.

@kdy1 kdy1 marked this pull request as ready for review September 18, 2020 05:11
@kdy1 kdy1 merged commit 7ffb4c0 into swc-project:master Sep 18, 2020
@kdy1 kdy1 deleted the ext-jest branch September 18, 2020 05:29
@bartlomieju
Copy link
Contributor

FYI @dsherret wrote jsonc-parser which we use successfully in Deno

@kdy1
Copy link
Member Author

kdy1 commented Sep 18, 2020

@bartlomieju Thanks! I think I can add support for path soon.

@Brooooooklyn
Copy link
Member

Brooooooklyn commented Sep 18, 2020

So is there any opportunity to have an independent tsconfig.json parse which be shared for deno and swc?

Seems like deno already have one? @bartlomieju

@bartlomieju
Copy link
Contributor

So is there any opportunity to have an independent tsconfig.json parse which be shared for deno and swc?

Seems like deno already have one? @bartlomieju

@Brooooooklyn the actual parsing of tsconfig.json is just a few lines - in Deno in process that config to exclude a lot of settings that we ignore.

@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Extension packages with hidden option.

3 participants