Skip to content

build(swcx): rename entrypoint to avoid artifact collision #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kdy1 merged 1 commit into from
Mar 2, 2022
Merged

build(swcx): rename entrypoint to avoid artifact collision #3806

kdy1 merged 1 commit into from
Mar 2, 2022

Conversation

@kwonoj
Copy link
Member

@kwonoj kwonoj commented Mar 1, 2022

Description:

Gh action uses wide match to upload native binary artifacts

with:
    name: bindings-x86_6[4](https://github.com/swc-project/swc/runs/5377724303?check_suite_focus=true#step:13:4)-apple-darwin
    path: swc*

which makes swcx.js also hits those. PR renames entrypoint try to avoid those collision.

BREAKING CHANGE:

Related issue (if exists):

kdy1
kdy1 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 added this to the v1.2.148 milestone Mar 2, 2022
@kdy1 kdy1 merged commit b485a2f into swc-project:main Mar 2, 2022
@kdy1 kdy1 modified the milestones: v1.2.148, v1.2.147 Mar 2, 2022
@kwonoj kwonoj deleted the rename-swcx-entrypoint branch March 5, 2022 04:52
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v1.2.147

Development

Successfully merging this pull request may close these issues.

2 participants

@kwonoj @kdy1