Skip to content

Conversation

@ojwb
Copy link
Member

@ojwb ojwb commented Dec 21, 2023

See #1567

@ojwb ojwb requested a review from wsfulton December 21, 2023 04:24
@ojwb ojwb added this to the swig-4.2 milestone Dec 21, 2023
@ojwb
Copy link
Member Author

ojwb commented Dec 21, 2023

@wsfulton This adds the warning for Perl and Ruby too, but I wonder if there's a better approach to implementing this? The dummy=1 parameter this adds for other uses of these typemaps seems ugly, but warning=Warning results in an empty warning message (hmm, perhaps warning= should be changed to not emit a warning at all?)

@ojwb ojwb force-pushed the string_view-directorout-warning-for-perl-and-ruby branch from 733c85b to 7fbae5e Compare December 21, 2023 20:38
@ojwb
Copy link
Member Author

ojwb commented Dec 21, 2023

Gah, I meant to push the PHP fix to master not this branch - I've move it there and force pushed to remove.

The intended change here breaks several other languages so clearly can't be merged as-is. Sorry but the maze of macros that is the UTL isn't something to be hacking at in a rush and I've also pretty much run out of time when I can look at this this year, having already spent more time than I really had spare this week on SWIG ("mid to end of December" really doesn't seem a good choice for a release deadline - it's especially problematic in the Southern hemisphere as it's Summer as well as xmas and the new year).

@wsfulton If you can see a better way to achieve this, please go for it. Otherwise I suggest we just don't have this warning for Perl and Ruby for 4.2.0.

@ojwb ojwb removed this from the swig-4.2 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant