Use C++11 std::mutex with MSVC too #3157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for _MSVC_LANG in addition to checking for __cplusplus as MSVC compiler still doesn't define the latter by default, even if supports not just C++11 but even much later standards. This notably avoids including <windows.h> from this file which wreaks havoc with the code after it due to the definitions of many common names as macros in it.
Member
Member
Author
|
I've seen this, but those were issues and this one is a tiny PR which fixes an actual problem and I honestly can't see any reason not to apply it. It doesn't cost anything now, it doesn't create any maintenance problems in the future and I'd rather solve this problem than waste time saying that it shouldn't exist (yes, it would be nice if MSVS started defining Anyhow, I'm submitting this in good faith because I'm 100% sure that this will help SWIG users to avoid problems, but if it gets rejected, so be it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for _MSVC_LANG in addition to checking for __cplusplus as MSVC compiler still doesn't define the latter by default, even if supports not just C++11 but even much later standards.
This notably avoids including <windows.h> from this file which wreaks havoc with the code after it due to the definitions of many common names as macros in it.
I know that you can force MSVC to define
__cplusplusby using the corresponding non-default/Zswitch but IMO it doesn't cost anything to also handle the case when this switch is not used gracefully instead of falling back to using Windows critical section which is less efficient (std::mutex uses SRW locks) and results in problems due to defining plenty of common symbols inwindows.h.