Handle SIGHUP signal in dontdie #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implemented features include a specification for a maximum file size of log files to prevent them from becoming too large. Also, added a handler for SIGHUP signals in order to intuitive processes control. Furthermore, set Shanghai as the default timezone.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ci #225 +/- ##
=========================================
Coverage 52.74% 52.74%
Complexity 1023 1023
=========================================
Files 96 96
Lines 13056 13056
=========================================
Hits 6886 6886
Misses 6170 6170 ☔ View full report in Codecov by Sentry. |
added 3 commits
November 13, 2023 16:47
This commit removes unnecessary white spaces and refactors how worker execution checks are implemented in the 'dontdie' library. Instead of having separate if statements to check each worker's execution status (stderrWorker, sigintWorker, etc.), a single loop has been used to iterate over and check all workers. This change not only reduces redundancy but also improves code readability.
Extra line breaks have been added in the dontdie file to improve code readability. The changes don't modify any functionalities, they just aim to create a cleaner and more readable code structure.
SplFileInfo is added to check the size of the log file instead of using file_exists and filesize. This change provides a more object-oriented way to handle filesystem entities and creates cleaner and more readable code.
added 2 commits
November 16, 2023 10:41
Unused 'SplFileInfo' class and 'MAX_FILE_SIZE' constant have been removed. The feature to limit log file size was removed, too. Also, the function call 'date_default_timezone_set('Asia/Shanghai');' was removed, avoiding forced timezone setting to Asia/Shanghai.
twose
approved these changes
Nov 16, 2023
lib/dontdie/bin/dontdie
Outdated
| } | ||
|
|
||
| date_default_timezone_set('Asia/Shanghai'); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implemented features include a specification for a maximum file size of log files to prevent them from becoming too large. Also, added a handler for SIGHUP signals in order to intuitive processes control. Furthermore, set Shanghai as the default timezone.