chore(ingest): change _ulid_ library to jsr:@std/ulid
#746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with this change bun bumped some minor versions.
since we cannot _require_ ESM from CJS here.
frytg
approved these changes
Mar 13, 2025
Member
frytg
left a comment
There was a problem hiding this comment.
looks good 👍
added note about ESM switch here #734 (comment)
frytg
requested changes
Mar 13, 2025
Member
frytg
left a comment
There was a problem hiding this comment.
just noticed that we should also update the change in the readme https://github.com/swrlab/ard-eventhub?tab=readme-ov-file#third-party-components
and add .npmrc / @jsr:registry=https://npm.jsr.io or
[install.scopes]
jsr = "https://npm.jsr.io"
to bunfig?
also update install scope in bunfig
Member
Author
|
Since we mainly use bun I updated the |
Member
|
@weiland the old |
Member
Author
|
I updated the RP. The old |
frytg
approved these changes
Mar 14, 2025
|
Docker container is ready! VERSION: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with this change bun bumped some minor versions.
Resolves #737