feat: use ard feed api for livestreams, publishers and institutions… #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of a local file
950c387 to
b0dc958
Compare
b0dc958 to
f5733c0
Compare
frytg
requested changes
Mar 25, 2025
Member
frytg
left a comment
There was a problem hiding this comment.
Overall it looks great, but the current setup would slow down every processed event, since getPublisher gets called for every service of every element. We should either include the full download in the docker container (like in ard-vox), or only load it once upon container boot?
Contributor
Author
|
changed it now to retrieve it at the start and just read the file |
frytg
requested changes
May 14, 2025
Member
frytg
left a comment
There was a problem hiding this comment.
we shouldn't use console.log in production (use winston/ logger.log({ ... }) instead)
frytg
approved these changes
May 21, 2025
|
Docker container is ready! VERSION: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…instead of a local file. resolves #247