Add DG FreeOutflow boundary condition to GRMHD#4196
Merged
nilsdeppe merged 1 commit intosxs-collaboration:developfrom Sep 6, 2022
Merged
Add DG FreeOutflow boundary condition to GRMHD#4196nilsdeppe merged 1 commit intosxs-collaboration:developfrom
nilsdeppe merged 1 commit intosxs-collaboration:developfrom
Conversation
5 tasks
nilsdeppe
requested changes
Sep 1, 2022
Member
nilsdeppe
left a comment
There was a problem hiding this comment.
LGTM! A few minor things you can squash immediately :)
| * | ||
| * - However, regardless of whether the normal component of the spatial | ||
| * velocity $n_iv^i$ is pointing outward or inward, the lorentz factor \f$W\f$ | ||
| * is copied into ghost zone without any modification. |
Member
There was a problem hiding this comment.
Maybe write out (briefly) the justification we had for this?
| const Scalar<DataVector>& interior_lapse, | ||
| const tnsr::II<DataVector, 3, Frame::Inertial>& | ||
| interior_inv_spatial_metric) { | ||
| const size_t vector_size = get(interior_rest_mass_density).size(); |
Member
There was a problem hiding this comment.
vector_size -> number_of_grid_points
| auto& exterior_divergence_cleaning_field = | ||
| get<::Tags::TempScalar<2>>(temp_buffer); | ||
|
|
||
| determinant_and_inverse(make_not_null(&sqrt_det_spatial_metric), |
Member
There was a problem hiding this comment.
Is it not possible to get these two from the interior? If not, that's fine, just curious :)
Contributor
Author
There was a problem hiding this comment.
Turns out.. it can 😂
I pushed this change as a fixup since it comes with nontrivial change of codes
b9c2625 to
259243c
Compare
Contributor
Author
|
Squashed fixes to the first two comments and pushed a fixup for the third one. |
nilsdeppe
reviewed
Sep 2, 2022
Member
nilsdeppe
left a comment
There was a problem hiding this comment.
Looks good, one comment, you can squash that in right away :)
tests/Unit/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Test_FreeOutflow.cpp
Show resolved
Hide resolved
259243c to
72c61e0
Compare
nilsdeppe
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments