Make execution order of events deterministic #4255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the order depended on the hashing of Trigger memory addresses.
Now tests that events are correctly re-checked for readiness after they are run.
Previously the order depended on hashes of memory addresses. Additionally, triggers are now always tested in input-file order. Previously, the order that triggers were checked in would vary in a deterministic but not easily predictable manner throughout the evolution. This incurs an asymptotic runtime penalty because the vector of triggers is being looped over repeatedly, but unless the number of triggers becomes very large this effect should be negligible.
nilsdeppe
approved these changes
Sep 28, 2022
Member
nilsdeppe
left a comment
There was a problem hiding this comment.
Amazing :D This is much simpler of a change than I expected when we first talked about it!
knelli2
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: 760 of the changed lines are trivial input-file syntax changes.
This will hopefully solve lockups we have attributed to the ordering of reduction calls varying between nodes.
Proposed changes
Upgrade instructions
The syntax for the
EventsAndTriggersandEventsAndDenseTriggersinput-file sections has changed. Each?:entry should be changed fromto
This results in all event and trigger arguments indenting one additional level (typically two spaces).
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments