Start adding support for specifying the initial data in the input file #4261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidder
requested changes
Oct 15, 2022
Member
kidder
left a comment
There was a problem hiding this comment.
you can squash the one requested change
you can optionally add test coverage for the clone functions
| db::get<::Tags::AnalyticSolutionOrData>(box)); | ||
| } else { | ||
| ERROR( | ||
| "Either ::Tags::AnalyticSolutionOrData or BLAH must be in the " |
da73fba to
ebc58bd
Compare
Member
Author
|
I've rebased, filled in the tag name, and added tests of the clone functions. Thanks for the review! |
kidder
approved these changes
Oct 25, 2022
Member
|
ignoring clang-tidy boost error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR focuses on changes to generic code to support both the current hard-coded ID and to also support reading from the input file. Once the individual systems are converted we will have significant fewer executables and can much more easily add input file tests to CI since they won't increase build costs.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments