Skip to content

Conversation

@knelli2
Copy link
Contributor

@knelli2 knelli2 commented Nov 3, 2022

Proposed changes

The condition for increasing the timescale was slightly different than the condition in SpEC. This changes the condition to match SpEC.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

The condition for increasing the timescale was slightly different
than the condition in SpEC. This changes the condition to match
SpEC.
@knelli2 knelli2 added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Nov 3, 2022
@nilsdeppe nilsdeppe merged commit 227c33c into sxs-collaboration:develop Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Only changes a few lines of code, does a rename or is otherwise quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants