Skip to content

Conversation

@wthrowe
Copy link
Member

@wthrowe wthrowe commented Nov 11, 2022

The main annoyance cleaned up here is the need to modify the test whenever unit tests for Utilities are added or removed.

Also runs the test in a temporary directory to simplify cleanup and not have to guess at nonexistent file names, and factors out some repeated code.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

The main annoyance cleaned up here is the need to modify the test
whenever unit tests for Utilities are added or removed.

Also runs the test in a temporary directory to simplify cleanup and
not have to guess at nonexistent file names, and factors out some
repeated code.
@nilsdeppe nilsdeppe merged commit 526f2b3 into sxs-collaboration:develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants