Skip to content

Conversation

@kidder
Copy link
Member

@kidder kidder commented Nov 22, 2022

Proposed changes

Remove unused template parameter OverrideCubicFunctionsOfTime from evolution::dg::Initialization::Domain

Upgrade instructions

If you passed in two or more template parameters to evolution::dg::Initialization::Domain, eliminate the second one.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe merged commit 80e0cde into sxs-collaboration:develop Nov 28, 2022
@kidder kidder deleted the remove_unused_template_param branch November 29, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants