Skip to content

Conversation

@markscheel
Copy link
Contributor

This makes it easier to debug things.
Other FunctionsOfTime have stream operators.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

@markscheel markscheel added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Dec 9, 2022
Comment on lines 74 to +75

std::ostream& operator<<(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple test? Just something that checks the output?

knelli2
knelli2 previously approved these changes Dec 10, 2022
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can squash.

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please ping me when it's squashed and I'll merge :)

This makes it easier to debug things.
Other FunctionsOfTime have stream operators.
@markscheel
Copy link
Contributor Author

Squashed.

@knelli2
Copy link
Contributor

knelli2 commented Dec 12, 2022

@nilsdeppe Been squashed.

@nilsdeppe nilsdeppe enabled auto-merge December 12, 2022 18:13
@nilsdeppe nilsdeppe merged commit cff825d into sxs-collaboration:develop Dec 12, 2022
@markscheel markscheel deleted the FixedSpeedAddStream branch December 13, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Only changes a few lines of code, does a rename or is otherwise quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants