Skip to content

Add simple helper methods and sanity checks for TimeStepIds #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kidder merged 4 commits into from
Jan 20, 2023
Merged

Add simple helper methods and sanity checks for TimeStepIds #4626

kidder merged 4 commits into from
Jan 20, 2023

Conversation

@wthrowe
Copy link
Member

@wthrowe wthrowe commented Jan 19, 2023

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe
Move non-trivial TimeStepId methods to cpp
afeadc2
@wthrowe
Add TimeStepId helpers for advancing time
3bd077b
@wthrowe
Add sanity check on substep times
35d7891
@wthrowe
Forbid substeps in BoundaryHistory
7c1bf23 
We only use it with AdamsBashforth currently, and this interface will
probably need redesigning before adding any LTS substep methods.
@kidder kidder merged commit 75aba31 into sxs-collaboration:develop Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kidder kidder kidder approved these changes

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wthrowe @kidder @nilsdeppe