Skip to content

Add invoke and apply to TaggedContainers.hpp #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wthrowe merged 1 commit into from
Feb 21, 2023
Merged

Add invoke and apply to TaggedContainers.hpp #4737

wthrowe merged 1 commit into from
Feb 21, 2023

Conversation

@nilsdeppe
Copy link
Member

@nilsdeppe nilsdeppe commented Feb 16, 2023

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

wthrowe
wthrowe requested changes Feb 17, 2023
View reviewed changes
tests/Unit/DataStructures/Test_TaggedContainers.cpp Outdated

struct Function {
using return_tags = tmpl::list<Tags::MyDouble2>;
using argument_tags = tmpl::list<Tags::MyDouble>;
Copy link
Member

@wthrowe wthrowe Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with more than one entry in these lists.

@nilsdeppe nilsdeppe force-pushed the invoke_apply_tagged_containers branch from f37d6ac to dbd5be8 Compare February 20, 2023 19:30
@nilsdeppe
Copy link
Member Author

nilsdeppe commented Feb 20, 2023

Update test to check all cases of 0,1,2 args and return tags. I squashed immediately because this basically changed the entire test.

Thanks for the review!

@nilsdeppe nilsdeppe force-pushed the invoke_apply_tagged_containers branch from dbd5be8 to be17f8a Compare February 20, 2023 23:54
@wthrowe wthrowe merged commit d119afe into sxs-collaboration:develop Feb 21, 2023
@nilsdeppe nilsdeppe deleted the invoke_apply_tagged_containers branch September 14, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wthrowe wthrowe wthrowe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nilsdeppe @wthrowe