Skip to content

Write checkpoints to Checkpoints/ directory #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wthrowe merged 2 commits into from
Jun 12, 2023
Merged

Write checkpoints to Checkpoints/ directory #5079

wthrowe merged 2 commits into from
Jun 12, 2023

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Jun 6, 2023

Proposed changes

Preparation for #4996.

Upgrade instructions

Checkpoints are now written in the format Checkpoints/Checkpoint_0123.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested review from knelli2 and wthrowe June 6, 2023 18:02
@nilsvu nilsvu mentioned this pull request Jun 6, 2023
Merged
3 tasks
knelli2
knelli2 requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing

tests/InputFiles/ExampleExecutables/RandomAmr1D.yaml Outdated
Comment on lines 7 to 8
ExpectedOutput:
- SpectreCheckpoint000000
- Checkpoints/Checkpoint_000000
Copy link
Contributor

@knelli2 knelli2 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many zeros?

Copy link
Member Author

@nilsvu nilsvu Jun 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. There's a bug in the CMake testing code that I'll try to fix in a separate PR. Edit: #5080

@nilsvu nilsvu force-pushed the py_schedule_prepare2 branch from c2d0648 to e5e6399 Compare June 6, 2023 21:50
@nilsvu
Copy link
Member Author

nilsvu commented Jun 9, 2023

@wthrowe could you take this one as well?

wthrowe
wthrowe previously approved these changes Jun 9, 2023
View reviewed changes
@wthrowe
Copy link
Member

wthrowe commented Jun 9, 2023

Approved, but needs a rebase.

@nilsvu nilsvu force-pushed the py_schedule_prepare2 branch from e5e6399 to 693dadf Compare June 9, 2023 20:46
@nilsvu
Copy link
Member Author

nilsvu commented Jun 9, 2023

done

@wthrowe wthrowe merged commit 47c02a5 into sxs-collaboration:develop Jun 12, 2023
@nilsvu nilsvu deleted the py_schedule_prepare2 branch June 27, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wthrowe wthrowe wthrowe approved these changes

@knelli2 knelli2 knelli2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nilsvu @wthrowe @knelli2