Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Jul 14, 2023

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested review from kidder, nilsdeppe and wthrowe July 14, 2023 03:16
@wthrowe wthrowe requested a review from knelli2 July 14, 2023 03:40
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be weird if I didn't approve this, right???

@nilsvu
Copy link
Member Author

nilsvu commented Jul 14, 2023

No, now you have accepted the weight of responsibility :P

@knelli2
Copy link
Contributor

knelli2 commented Jul 14, 2023

🏋🏻‍♂️ 💪🏻

@nilsdeppe nilsdeppe merged commit ecf9f7d into sxs-collaboration:develop Jul 14, 2023
@nilsdeppe
Copy link
Member

And now you're stuck with it ;) Welcome aboard!

@nilsvu nilsvu deleted the core_devs branch July 14, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants