Mock global cache #5319
Merged
Mock global cache #5319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
requested changes
Aug 7, 2023
Member
nilsdeppe
left a comment
There was a problem hiding this comment.
LGTM, one small suggestion, squash & rebase if you decide to make the change
| ${CHARM_LIB_ckmain} | ||
| ${CHARM_LIB_conv-static} | ||
| ) | ||
| target_compile_definitions( |
Member
There was a problem hiding this comment.
It might be a good idea to add a brief comment here what one of the intended uses for this definition is. basically just the long part of the commit message.
69c3e1b to
c335252
Compare
nilsdeppe
previously approved these changes
Aug 7, 2023
knelli2
requested changes
Aug 8, 2023
Comment on lines
817
to
824
| if constexpr (not GlobalCache<Metavariables>::is_mocked) { | ||
| cache.thisProxy.template mutate<GlobalCacheTag, Function>( | ||
| std::make_tuple<Args...>(std::forward<Args>(args)...)); | ||
| } |
Contributor
There was a problem hiding this comment.
So if the main proxy somehow has been set but the cache is mocked, this won't do anything?
Member
Author
There was a problem hiding this comment.
I'll add an error to avoid silently hitting this for some reason
Charm registration only works with a Main module, so enable it only when the Main module is available. This allows the Charm registration code to compile in unit tests that use the mocking framework and don't link a Charm Main module.
Mock the global cache in unit tests that don't run in a Charm++ environment.
c335252 to
bd6baf2
Compare
knelli2
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allows to run most tests outside a Charm++ environment.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments