Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 17, 2023

Proposed changes

@nilsdeppe feel free to merge this when you're confident that we don't need it anymore.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Not needed anymore.
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this out a bit. Works great! Thank you again for doing all this!

@nilsdeppe nilsdeppe enabled auto-merge August 17, 2023 21:43
@nilsdeppe nilsdeppe merged commit e6b8c5a into sxs-collaboration:develop Aug 17, 2023
@nilsvu nilsvu deleted the delete_runsingletest branch August 17, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants