Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Sep 15, 2023

Used to control the linear momentum of the system.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Sep 15, 2023
wthrowe
wthrowe previously approved these changes Sep 15, 2023
knelli2
knelli2 previously approved these changes Sep 15, 2023
@knelli2
Copy link
Contributor

knelli2 commented Sep 15, 2023

Just missed a couple input files

Used to control the linear momentum of the system.
@nilsvu nilsvu dismissed stale reviews from knelli2 and wthrowe via ab94292 September 15, 2023 18:23
@knelli2
Copy link
Contributor

knelli2 commented Sep 18, 2023

Test failures are addressed in #5469 (except for BBH running out of memory)

@knelli2 knelli2 merged commit 106a0ed into sxs-collaboration:develop Sep 18, 2023
@nilsvu nilsvu deleted the linear_velocity branch October 4, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Only changes a few lines of code, does a rename or is otherwise quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants