Add debug prints to interpolation framework #5519
Conversation
|
@markscheel Opened as a draft for now so you can take a look at things while this is being tested out on a run that deadlocks. |
a6e286f to
b4ad27c
Compare
| template <typename InterpolationTargetTag, typename TemporalId> | ||
| std::string interpolator_output_prefix(const TemporalId& temporal_id) { |
There was a problem hiding this comment.
These should return the std::stringstream instead so whatever else can take advantage of the scientific precision. Or just take a std::stringstream& as an argument.
b4ad27c to
f53be7e
Compare
fc12dbb to
3e25f02
Compare
|
@knelli2 will look into this |
3e25f02 to
680befb
Compare
|
I found these commits to be useful when debugging the interpolation framework for spherical shells. Is there any reason not to rebase and get this in? |
|
@kidder No, just wasn't super high priority for me so I put it on the back burner. But if you'd like I can rebase and we can get these merged |
|
well if you rebase it, I'll approve and merge... No rush as I found my problem... |
680befb to
2d65992
Compare
|
@kidder Rebased and opened as a PR |
2d65992 to
8e956d5
Compare
Proposed changes
Upgrade instructions
If your executable has the
InterpolatororInterpolationTargetparallel component, you need the following in your input fileCode review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments