Add the exact Wald solution to ForceFree system #5527
Conversation
3f287ea to
6d8f000
Compare
wthrowe
left a comment
There was a problem hiding this comment.
The other clang-tidy warning is legitimate.
| namespace ForceFree::Solutions { | ||
|
|
||
| ExactWald::ExactWald(const double magnetic_field_amplitude, | ||
| const Options::Context& /*context*/) |
There was a problem hiding this comment.
[optional] If you don't use the context you can omit the argument and the option parser will figure out not to pass it.
| p | magnetic_field_amplitude_; | ||
| } | ||
|
|
||
| PUP::able::PUP_ID ExactWald::my_PUP_ID = 0; |
There was a problem hiding this comment.
Just NOLINT this to make clang-tidy happy. We can't do anything about charm internals.
| struct MagneticFieldAmplitude { | ||
| using type = double; | ||
| static constexpr Options::String help = { | ||
| "Amplitude of initial magnetic field along z axis."}; |
There was a problem hiding this comment.
This is time-independent, so remove "initial".
|
|
||
| /*! | ||
| * \brief An exact electrovacuum solution of Maxwell's equations in the Kerr | ||
| * spacetime found by Wald \cite Wald1974. |
There was a problem hiding this comment.
Kerr -> Schwarzschild? The paper is valid for arbitrary spin, but only the zero-spin case is implemented (and I take it that the spinning case isn't a solution to the force-free equations.)
| * \brief Typelist of all analytic solutions of GRFFE evolution system | ||
| */ | ||
| using all_solutions = tmpl::list<AlfvenWave, FastWave>; | ||
| using all_solutions = tmpl::list<AlfvenWave, FastWave, ExactWald>; |
| const std::unique_ptr<InitialData> deserialized_base_ptr = | ||
| serialize_and_deserialize(base_ptr)->get_clone(); | ||
| CHECK(dynamic_cast<const ExactWald&>(*deserialized_base_ptr.get()) == | ||
| dynamic_cast<const ExactWald&>(*base_ptr.get())); |
There was a problem hiding this comment.
Remove .get() form these two lines.
6d8f000 to
6ab54bc
Compare
|
Looks good. Squash. |
5d6bdad to
57a6127
Compare
|
Squashed and rebased on develop. Thanks for review. |
57a6127 to
ee0012f
Compare
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.