Skip to content

Conversation

@Sizheng-Ma
Copy link
Contributor

Proposed changes

This PR performs hypersurface calculations for Klein-Gordon Cce.

The first commit does a worldtube transformation to convert the Cauchy variable $\partial_{t^\prime}\psi$ to the characteristic variable $\Pi$ (Cce::Tags::KleinGordonPi).

The third commit adds actions to compute the right-hand side of the hypersurface equation for $\Pi$. The equation reads

$(1 - y) \partial_y \Pi + \Pi = A_\Pi + (1 - y) B_\Pi$.

The second commit prepares necessary inputs to compute $A_\Pi$ and $B_\Pi$.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@Sizheng-Ma Sizheng-Ma force-pushed the kg_cce_hypersurface_calculations branch from 7375985 to fc87e28 Compare March 29, 2024 20:40
@Sizheng-Ma Sizheng-Ma force-pushed the kg_cce_hypersurface_calculations branch 2 times, most recently from 09f9060 to 0c2541c Compare April 16, 2024 00:55
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes! You can squash everything together, including this last change.

@Sizheng-Ma Sizheng-Ma force-pushed the kg_cce_hypersurface_calculations branch 2 times, most recently from 73e1e02 to 5581c6d Compare April 16, 2024 11:41
@Sizheng-Ma Sizheng-Ma force-pushed the kg_cce_hypersurface_calculations branch from 5581c6d to 5aa2887 Compare April 16, 2024 11:47
@knelli2 knelli2 merged commit a8aa129 into sxs-collaboration:develop Apr 16, 2024
@Sizheng-Ma Sizheng-Ma deleted the kg_cce_hypersurface_calculations branch April 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants