Add ErrorIfDataTooBig to BBH pipeline #6014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f99d31d to
a9a90e7
Compare
wthrowe
approved these changes
May 22, 2024
nilsdeppe
reviewed
May 22, 2024
| Events: | ||
| - ErrorIfDataTooBig: | ||
| Threshold: 100 | ||
| VariablesToCheck: [SpacetimeMetric] |
Member
There was a problem hiding this comment.
Question: why not monitor the constraints during the ringdown? No need to hold up the PR aboutt this, I'm just surprised
Contributor
Author
There was a problem hiding this comment.
I don't actually know, but if I were to venture a guess it'd be because the constraint violations at t=Ringdown may be pretty large initially and then settle down quickly, so that initial violation could have been over the threshold? But then why not just delay the trigger? I'm not really sure. We should ask @markscheel at the BBH meeting today.
Member
There was a problem hiding this comment.
Sounds good! I think SpEC actually monitors the constraints outside the horizons, but that's obviously harder to do.
isaaclegred
pushed a commit
to isaaclegred/spectre
that referenced
this pull request
May 23, 2024
…too_big Add ErrorIfDataTooBig to BBH pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
These variables and thresholds were used in SpEC.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments