Skip to content

Conversation

@geoffrey4444
Copy link
Contributor

Proposed changes

Add python bindings to ModalVector, which will be needed for the merger->ringdown transition for BBH evolutions.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@geoffrey4444 geoffrey4444 requested a review from knelli2 May 22, 2024 14:09
@kidder kidder merged commit fe73eaa into sxs-collaboration:develop May 22, 2024
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli/pybindings Command line interface & Python bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants