Skip to content

Conversation

@wthrowe
Copy link
Member

@wthrowe wthrowe commented May 21, 2024

Also clean up duplicated ScalarTensor filtering.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

nilsdeppe
nilsdeppe previously approved these changes May 21, 2024
@geoffrey4444
Copy link
Contributor

geoffrey4444 commented May 22, 2024

@wthrowe you beat me to it! I will close my PR #6018 which duplicates this. Closed yours by accident, reopened, sorry!

@knelli2 knelli2 enabled auto-merge May 22, 2024 18:03
@knelli2 knelli2 added the auto-merge GitHub's auto-merge has been enabled for this PR. label May 22, 2024
@knelli2 knelli2 merged commit 3437f38 into sxs-collaboration:develop May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge GitHub's auto-merge has been enabled for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants