Skip to content

More minor code for nodegroup elements #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knelli2 merged 5 commits into from
May 29, 2024
Merged

More minor code for nodegroup elements #6027

knelli2 merged 5 commits into from
May 29, 2024

Conversation

@nilsdeppe
Copy link
Member

@nilsdeppe nilsdeppe commented May 24, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe requested a review from kidder May 24, 2024 02:30
kidder
kidder requested changes May 24, 2024
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can squash

knelli2
knelli2 requested changes May 25, 2024
View reviewed changes
@nilsdeppe
Copy link
Member Author

nilsdeppe commented May 28, 2024

I've rebased and pushed fixups. I added a decent number of words for the return type being size_t since that is important. I'll need to clean this class up a bit after everything is working, mostly just the documentation. I also added value_type as a type alias since this is actually what the STL uses. It's not used right now, though.

kidder
kidder reviewed May 28, 2024
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixups LGTM

knelli2
knelli2 approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixups look good. Squash and rebase

@nilsdeppe
Copy link
Member Author

nilsdeppe commented May 29, 2024

Done! Thanks!

@knelli2 knelli2 enabled auto-merge May 29, 2024 03:35
@knelli2 knelli2 added the auto-merge GitHub's auto-merge has been enabled for this PR. label May 29, 2024
@knelli2 knelli2 merged commit 852add9 into sxs-collaboration:develop May 29, 2024
@nilsdeppe nilsdeppe deleted the add_threading_10 branch August 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kidder kidder kidder approved these changes

@knelli2 knelli2 knelli2 approved these changes

Assignees

No one assigned

Labels

auto-merge GitHub's auto-merge has been enabled for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nilsdeppe @kidder @knelli2