Move element distribution code from DgElementArray to free function #6028
Conversation
This allows us to share the creation code between the evolution array and nodegroup implementations
| quadrature, | ||
|
|
There was a problem hiding this comment.
Is formatting really ok with this space in the function call?
There was a problem hiding this comment.
I'm not exactly sure what you mean by "okay". Clang format doesn't remove single blank lines (it does combine multiple blank lines into one!) and I found it easier to read the function call separating the slew of size_ts that represent hardware things from the parts that are tied to the element info 🤷
There was a problem hiding this comment.
Hmm do we have a convention for this? I think there are many other instances of function calls that have a bajillion parameters that are difficult to read. Some have comments between lines to make it easier, some don't. Not gonna hold up this PR though, but we should probably figure out what to do
| quadrature, | ||
|
|
There was a problem hiding this comment.
Hmm do we have a convention for this? I think there are many other instances of function calls that have a bajillion parameters that are difficult to read. Some have comments between lines to make it easier, some don't. Not gonna hold up this PR though, but we should probably figure out what to do
Proposed changes
I'll need to share this with the nodegroup code.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments