Skip to content

Set up ghost zones for MC #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsdeppe merged 1 commit into from
Jun 13, 2024
Merged

Set up ghost zones for MC #6037

nilsdeppe merged 1 commit into from
Jun 13, 2024

Conversation

@ffoucart
Copy link
Contributor

@ffoucart ffoucart commented May 29, 2024

Proposed changes

Builds infrastructure for the use of GZ within the MC code.

Upgrade instructions

NA

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@ffoucart
Copy link
Contributor Author

ffoucart commented May 29, 2024

Depends on #5907

@ffoucart ffoucart added the dependent Needs a different PR to be merged in first label May 29, 2024
@ffoucart ffoucart force-pushed the GZinTakeTimeStep branch 2 times, most recently from 887b0c7 to 216186a Compare June 4, 2024 17:39
@ffoucart
Copy link
Contributor Author

ffoucart commented Jun 4, 2024

Start handling ghost zones by:
(1) Getting GZ data for density, temperature, Ye as input to the MC code
(2) Assuming that neutrino emission/absorption/scattering are computed on an extended mesh with GZ
(3) Assuming that coupling to the fluid is compute on an extended mesh
As part of this change, the proper volume term going in the calculation of the emission rate has been moved to the emitpacket function.

This does not allow packets to move from cell to cell yet (#5998 will be needed for that)

@ffoucart ffoucart marked this pull request as ready for review June 4, 2024 17:47
@ffoucart ffoucart mentioned this pull request Jun 4, 2024
Closed
3 tasks
@ffoucart ffoucart force-pushed the GZinTakeTimeStep branch from 216186a to 39ff2cf Compare June 5, 2024 13:59
@ffoucart ffoucart removed the dependent Needs a different PR to be merged in first label Jun 5, 2024
@ffoucart
Copy link
Contributor Author

ffoucart commented Jun 5, 2024

Rebased against 5907 and 5998. Should now be up to date with the current state of develop and ready for full review.

@ffoucart ffoucart force-pushed the GZinTakeTimeStep branch from 39ff2cf to 011a20f Compare June 5, 2024 14:09
kidder
kidder approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me.

@ffoucart ffoucart mentioned this pull request Jun 6, 2024
Merged
3 tasks
@nilsdeppe nilsdeppe merged commit aca73fe into sxs-collaboration:develop Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kidder kidder kidder approved these changes

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ffoucart @kidder @nilsdeppe