Update how often constraints are observed in BBH inspiral pipeline #6039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constraint energy is expensive to compute and so isn't observed as often. Since we want the status to give us a current snapshot, use the 3-index constraint instead since we compute it more often because it's cheap to compute.
nilsdeppe
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is currently only done for inspiral because I honestly don't know how often we'll want it done for ringdown and there's so many other changes that have to happen for the ringdown yaml that it didn't seem necessary to incorrectly guess here.
Also changed the BBH status in the CLI to print the 3-index constraint instead of the constraint energy because we observe the 3-index more often now and a "status" seemed like it should be updated pretty often to give an accurate snapshot of the simulation.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments