Skip to content

Add DgElementArrayMember #6042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsdeppe merged 1 commit into from
Jun 1, 2024
Merged

Add DgElementArrayMember #6042

nilsdeppe merged 1 commit into from
Jun 1, 2024

Conversation

@nilsdeppe
Copy link
Member

@nilsdeppe nilsdeppe commented May 29, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe requested a review from kidder May 29, 2024 19:30
kidder
kidder requested changes May 31, 2024
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nolint the clang-tidy error?

a lot of this code looks like it is copied from a DistributedObject. Should these functions be factored out?

you can squash any changes

src/Parallel/ArrayCollection/DgElementArrayMember.hpp Outdated
tmpl::list<typename PhaseDepActionListsPack::action_list...>>;
/// The metavariables class passed to the Algorithm
using metavariables = Metavariables;
/// List off all the Tags that can be received into the Inbox
Copy link
Member

@kidder kidder May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off -> of

@nilsdeppe
Copy link
Member Author

nilsdeppe commented Jun 1, 2024

  1. added nolint for one. I don't know what to do about the other. The code seems to compile with clang so I don't know why clang-tidy is having issues.
  2. Probably in the long run. I didn't mostly because we'll also need to test switching to a group instead of nodegroup to get it working with Kokkos, so just a lot of imminent changes that I don't know what they will require.
  3. I've rebased and squashed. Thanks for the review!

@nilsdeppe nilsdeppe merged commit f3013ad into sxs-collaboration:develop Jun 1, 2024
@nilsdeppe nilsdeppe deleted the add_threading_14 branch August 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kidder kidder kidder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nilsdeppe @kidder