Add code to get common horizon coefs in ringdown distorted frame #6065
Conversation
|
I will fix the clang-tidy failures and look into why clang is happy but gcc isn't |
7c175c8 to
3e46eee
Compare
|
Clang-tidy is fixed, and the gcc test failures are fixed. The test that did fail is unrelated to this PR |
src/Evolution/Ringdown/StrahlkorperCoefsInRingdownDistortedFrame.hpp
Outdated
Show resolved
Hide resolved
| const Matrix& coefs_for_times = | ||
| ahc_h5_file.get<h5::Dat>(surface_subfile_name).get_data(); |
There was a problem hiding this comment.
In order to avoid reading all coefficients in, use get_data_subset instead.
const Matrix ahc_times = ahc_h5_file.get<h5::Dat>(
surface_subfile_name).get_data_subset({0}, 0, ahc_inertial_h5.size());There was a problem hiding this comment.
except I want the last requested_number_of_times_from_end , not the first requested_number_of_times_from_end
src/Evolution/Ringdown/StrahlkorperCoefsInRingdownDistortedFrame.cpp
Outdated
Show resolved
Hide resolved
src/Evolution/Ringdown/StrahlkorperCoefsInRingdownDistortedFrame.cpp
Outdated
Show resolved
Hide resolved
tests/Unit/Evolution/Ringdown/Test_StrahlkorperCoefsInRingdownDistortedFrame.cpp
Outdated
Show resolved
Hide resolved
| const auto kerr_horizon_radius = get(gr::Solutions::kerr_horizon_radius( | ||
| ::ylm::Spherepack(l_max, m_max).theta_phi_points(), 1.0, | ||
| {{0.0, 0.0, 0.8}})); | ||
| const auto expected_strahlkorper = ylm::Strahlkorper<Frame::Grid>( | ||
| l_max, m_max, kerr_horizon_radius, expected_center); |
There was a problem hiding this comment.
If this is just supposed to be a Schwarzschild horizon of radius 1, you could do
const ylm::Strahlkorper<Frame::Grid> expected_strahlkorper{
l_max, 1.0, {0.0, 0.0, 0.0};There was a problem hiding this comment.
I deliberately wanted it to be a Kerr horizon with spin 0.8, so some coefs are nontrivial
There was a problem hiding this comment.
Oh oops I misread this. The 8 blended in with all the 0s
tests/Unit/Evolution/Ringdown/Test_StrahlkorperCoefsInRingdownDistortedFrame.cpp
Show resolved
Hide resolved
tests/Unit/Evolution/Ringdown/Test_StrahlkorperCoefsInRingdownDistortedFrame.cpp
Outdated
Show resolved
Hide resolved
tests/Unit/Evolution/Ringdown/Test_StrahlkorperCoefsInRingdownDistortedFrame.cpp
Outdated
Show resolved
Hide resolved
46d1e08 to
5ef8294
Compare
|
Test failures look to me unrelated to this PR |
|
Yeah they do look unrelated, but I restarted them anyways. If there are still timeouts, I'll just merge this. |
Proposed changes
This PR is the first in a set that will enable transitioning from merger to ringdown in binary black hole simulations. This PR adds a C++ function that reads in common horizon coefficients from a file and transforms them to the ringdown distorted frame. A future PR will add a pybinding to this function and use that binding in an update to the Ringdown pipeline.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments