Support complex numbers in PartialDerivatives #6107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26aa312 to
37d9973
Compare
0e20438 to
a4bbc8f
Compare
Member
Author
|
@nilsdeppe or @wthrowe would one of you take this one? |
wthrowe
requested changes
Aug 21, 2024
| SPECTRE_TEST_CASE("Unit.Numerical.DiscontinuousGalerkin.ApplyMassMatrix", | ||
| "[NumericalAlgorithms][Unit]") { | ||
| template <typename DataType> | ||
| void test_apply_mass_matrix() { |
Member
There was a problem hiding this comment.
Put this in the anonymous namespace.
| 0.0, // overwrite output with result | ||
| result, // result | ||
| matrix.rows()); // rows of result | ||
| add_to_result ? 1.0 : 0.0, // overwrite output with result |
| input, // input | ||
| matrix.columns(), // rows of input | ||
| std::complex{add_to_result ? 1.0 : 0.0, | ||
| 0.0}, // overwrite output with result |
| imaginary_part = std::complex<double>(0., static_cast<double>(i) + 3); | ||
| for (size_t d = 0; d < Dim; ++d) { | ||
| imaginary_part *= | ||
| std::complex<double>(0., static_cast<double>(d) + 2) * |
Member
There was a problem hiding this comment.
Should this be real? Multiplying by an imaginary number makes imaginary_part real half the time. Same thing a couple more times below.
wthrowe
previously approved these changes
Aug 21, 2024
Member
wthrowe
left a comment
There was a problem hiding this comment.
Looks good. Squash.
@nilsdeppe I think you said you wanted to take a final look at this?
691bb97 to
9c37796
Compare
nilsdeppe
requested changes
Aug 22, 2024
a2adda9 to
38c8f31
Compare
Member
Author
|
Also added an extra commit at the end to add complex support to |
38c8f31 to
71d9d58
Compare
wthrowe
approved these changes
Aug 23, 2024
Member
wthrowe
left a comment
There was a problem hiding this comment.
I'll grumble about improper use of detail namespaces, but I'll allow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments