Support complex numbers in serial linear solvers, add BLAS zdot #6117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f0bbed to
2e0a9e1
Compare
548e8a0 to
2621cc6
Compare
Member
Author
|
@wthrowe would you be willing to review this one? |
wthrowe
requested changes
Jul 16, 2024
Member
wthrowe
left a comment
There was a problem hiding this comment.
Looks overall OK, but it's not compiling, and it looks like the intermediate commits won't compile even after the overall problems are fixed.
| double>); | ||
| static_assert(std::is_same_v<typename tt::get_complex_or_fundamental_type_t< | ||
| std::vector<std::complex<int>>>, | ||
| std::complex<int>>); |
Member
There was a problem hiding this comment.
std::complex is only guaranteed to work for floating-point types.
| INFO("Build a simple dense matrix"); | ||
| const blaze::DynamicMatrix<double> matrix{{4., 1.}, {3., 1.}}; | ||
| const helpers::ApplyMatrix linear_operator{matrix}; | ||
| const helpers::ApplyMatrix<double> linear_operator{matrix}; |
Member
|
Still doesn't compile. |
42d9f40 to
6db96f4
Compare
Member
Author
|
Should be fixed now! |
wthrowe
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds complex numbers support to the serial linear solvers, which are used as preconditioners in the parallel linear solvers. Most notably, extends the GMRES algorithm to complex arithmetics, which involves the inner product on the vector space of complex numbers.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments