Skip to content

Fix Test_DgSubcell for GCC 13.2 #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wthrowe merged 1 commit into from
Jun 27, 2024
Merged

Fix Test_DgSubcell for GCC 13.2 #6119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/Unit/Evolution/DgSubcell/Test_BackgroundGrVars.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,9 @@ void test(const gsl::not_null<std::mt19937*> gen, const bool did_rollback) {
auto box = [&block, &brick, &dg_gr_vars, &element, &element_id,
&grid_to_inertial_map, &initial_time, &solution,
&subcell_initial_inertial_coords, &subcell_mesh]() {
// Bug in GCC 13.2 where having this class created in-place below causes an
// internal compiler error
typename subcell_face_gr_variables_tag::type face_gr_vars{};
// Since we want to test that the BackgroundGrVars action properly
// initializes (allocate + assign) the background GR variables on
// cell-centered and face-centered coordinates, use an empty subcell GR
Expand Down Expand Up @@ -276,8 +279,7 @@ void test(const gsl::not_null<std::mt19937*> gen, const bool did_rollback) {
std::move(grid_to_inertial_map),
clone_unique_ptrs(brick.functions_of_time()), subcell_mesh,
subcell_initial_inertial_coords, dg_gr_vars,
typename inactive_gr_variables_tag::type{},
typename subcell_face_gr_variables_tag::type{}, false,
typename inactive_gr_variables_tag::type{}, face_gr_vars, false,
solution.get_clone());
} else {
return db::create<db::AddSimpleTags<
Expand All @@ -301,8 +303,8 @@ void test(const gsl::not_null<std::mt19937*> gen, const bool did_rollback) {
std::move(grid_to_inertial_map),
clone_unique_ptrs(brick.functions_of_time()), subcell_mesh,
subcell_initial_inertial_coords, dg_gr_vars,
typename inactive_gr_variables_tag::type{},
typename subcell_face_gr_variables_tag::type{}, false, solution);
typename inactive_gr_variables_tag::type{}, face_gr_vars, false,
solution);
}
}();

Expand Down