Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 4, 2024

Proposed changes

Something about the current fixed camera positions doesn't work, so the camera is very far away. This zoom factor fixes that.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from knelli2 August 4, 2024 19:26
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Aug 4, 2024
@knelli2 knelli2 added the priority critical for progress label Aug 4, 2024
@knelli2
Copy link
Contributor

knelli2 commented Aug 4, 2024

Merging now because it's small, and the bbh rendering script isn't tested on CI, and because we need it for the workshop

@knelli2 knelli2 merged commit e12c810 into sxs-collaboration:develop Aug 4, 2024
@nilsvu nilsvu deleted the pv_bbh_zoom branch October 22, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli/pybindings Command line interface & Python bindings priority critical for progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants