Skip to content

Conversation

@knelli2
Copy link
Contributor

@knelli2 knelli2 commented Aug 13, 2024

We aren't going to use charm LB anymore and this only serves to hit a segfault every once in a while on CI which is annoying.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added the ci/cd Continuous integration & deployment label Aug 13, 2024
@knelli2 knelli2 requested a review from kidder August 13, 2024 17:42
@knelli2 knelli2 mentioned this pull request Aug 13, 2024
13 tasks
@kidder
Copy link
Member

kidder commented Aug 14, 2024

RIP that was an unexpected dependency 😛

@knelli2 knelli2 force-pushed the disable_burgers_lb branch from 86f9161 to 3c8b707 Compare August 14, 2024 03:32
@kidder kidder enabled auto-merge August 14, 2024 14:44
We aren't going to use charm LB anymore and this only serves to
hit a segfault every once in a while on CI which is annoying.
@knelli2 knelli2 force-pushed the disable_burgers_lb branch from 3c8b707 to 19c3cb9 Compare August 16, 2024 01:13
@kidder kidder merged commit 705a34b into sxs-collaboration:develop Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration & deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants