Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 24, 2024

Proposed changes

This variant of the elliptic DG formulation moves the Jacobian into the divergence like this:

$$ \partial_i F^i = \frac{1}{J} \partial_\hat{\imath} J {J^{-1}}^{\hat{\imath}}_j F^j $$

This formulation makes the strong scheme work as well as the weak scheme for extremely stretched grids (initial data with large outer boundaries).

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from nilsdeppe August 25, 2024 21:17
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple suggestions you can squash immediately.

@nilsdeppe nilsdeppe merged commit 806c656 into sxs-collaboration:develop Aug 27, 2024
@nilsvu nilsvu deleted the dg_paper_tests branch August 27, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants