Add single BH control system #6247
Conversation
bb49248 to
0fb8665
Compare
|
|
||
| namespace control_system::ControlErrors { | ||
| template struct Translation<1_st>; | ||
| template struct Translation<2_st>; |
There was a problem hiding this comment.
These don't do anything useful because the class is entirely defined in the hpp.
support/Pipelines/Bbh/Ringdown.yaml
Outdated
| MeasurementsPerUpdate: 4 | ||
| Verbosity: Silent | ||
| Translation: | ||
| IsActive: false |
0fb8665 to
8333b04
Compare
|
Squashed everything in |
8333b04 to
5f44dd3
Compare
wthrowe
left a comment
There was a problem hiding this comment.
clang-tidy timed out for no obvious reason. Rerunning to see if it was some sort of glitch. If it still times out I'm not going to worry about it.
|
@wthrowe I've seen clang-tidy time out on several PRs lately for what seems like no good reason (not that many files changed). I haven't tried to figure out why though |
|
Sounds like you fixed it in #6282. Want to rebase to pick that up? |
5f44dd3 to
f08d0da
Compare
|
I don't think #6282 was the issue as I'm pretty sure the clang-tidy timeouts were happening before I introduced that, but I rebased just in case. |
|
Actually, looks like your fix broke it more. CI is spewing errors. |
|
And then reporting itself as passed. |
f08d0da to
4025f32
Compare
wthrowe
left a comment
There was a problem hiding this comment.
Looks like that fixed clang-tidy. One of the errors there is legitimate, but it wasn't introduced in this PR and we should get the fix in quickly, so I'm not going to worry about it.
Proposed changes
Controls object to the origin of the domain.
Upgrade instructions
Must now specify a
Translation:control system inEvolveGhSingleBlackHoleinput files.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments