Skip to content

Conversation

@nilsdeppe
Copy link
Member

Proposed changes

There were a number of subtleties, and unfortunately the GDB documentation is essentially non-existent, but this resolves the issue. It does make the output not as pretty since I need to print the storage index instead of the component suffix. I don't know of an easy way around this, though.

@wthrowe would you mind testing this on your machine in case there's some GDB version-dependent behavior going on?

I'm leaving the evaluation string so we can revisit this in the future without having to learn all that again.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

There were a number of subtleties, and unfortunately the GDB documentation is
essentially non-existent, but this resolves the issue. It does make the output
not as pretty since I need to print the storage index instead of the component
suffix. I don't know of an easy way around this, though.
Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least basic printing tensors works.

@wthrowe wthrowe merged commit fa3590c into sxs-collaboration:develop Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants