Hitchhiker’s Guide Update #6304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
requested changes
Sep 25, 2024
Contributor
knelli2
left a comment
There was a problem hiding this comment.
Thank you for doing this! It's greatly appreciated when people take the time to update our tutorials :)
Couple overall things:
- Both in our code and in our docs, we limit the length of a line to 80 characters. Please split the lines you added to adhere to this.
- You can squash these changes into your original changes, and remove the merge commits on your branch. If you're not sure how to do this, we can go over how to do it on Slack.
8e61bc2 to
b377f27
Compare
knelli2
approved these changes
Sep 27, 2024
Contributor
|
@SunPeike Could you update the PR description? You don't say anything about Paraview 5.11.1 anymore. |
Contributor
|
Ignoring unrelated errors |
|
@SunPeike looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:
Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Hitchhiker’s Guide for SpECTRE.
Added necessary steps for using ParaView from clusters