Skip to content

Conversation

@wthrowe
Copy link
Member

@wthrowe wthrowe commented Oct 18, 2024

Proposed changes

Upgrade instructions

If using ErrorControl to choose a step size for local time stepping, you may have to tighten the error tolerances specified in the input file. The code previously often kept the actual error estimate significantly lower than the specified tolerance.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe merged commit 6e1258c into sxs-collaboration:develop Oct 23, 2024
knelli2 added a commit to knelli2/spectre that referenced this pull request Dec 17, 2024
knelli2 added a commit to knelli2/spectre that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants