Skip to content

Conversation

@PunJustice
Copy link
Contributor

Proposed changes

Allows a subset of argument_tags for the SourcesComputer to be fetched from the const_global_cache. This isn't used for anything right now, but will be used in an upcoming system.

Upgrade instructions

All Sources and LinearizedSources classes must now define the alias const_global_cache_tags.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@PunJustice PunJustice requested a review from nilsvu October 28, 2024 20:13
@nilsvu nilsvu enabled auto-merge October 28, 2024 20:15
@nilsvu nilsvu disabled auto-merge October 28, 2024 21:30
@nilsvu nilsvu merged commit 26063a7 into sxs-collaboration:develop Oct 28, 2024
22 of 23 checks passed
@PunJustice PunJustice deleted the const_global_cache branch October 28, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants