Skip to content

Conversation

@PunJustice
Copy link
Contributor

@PunJustice PunJustice commented Oct 28, 2024

Proposed changes

Template parts of boundary condition class on elliptic::analytic_data::InitialGuess instead of elliptic::analytic_data::AnalyticSolution, so that classes that aren't exactly analytic solutions to a given problem can still use them.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

solution_for_negative_expansion_.value()->get_clone())
deserialize<
std::unique_ptr<elliptic::analytic_data::InitialGuess>>(
serialize(solution_for_lapse_.value()).data()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUG ALARM

nilsvu
nilsvu previously approved these changes Oct 28, 2024
@nilsvu nilsvu enabled auto-merge October 28, 2024 21:45
auto-merge was automatically disabled October 29, 2024 03:05

Head branch was pushed to by a user without write access

@nilsvu nilsvu enabled auto-merge October 29, 2024 03:48
@nilsvu nilsvu merged commit 4d6f679 into sxs-collaboration:develop Oct 29, 2024
23 checks passed
@PunJustice PunJustice deleted the XctsBC branch October 29, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants