Skip to content

Conversation

@kidder
Copy link
Member

@kidder kidder commented Nov 13, 2024

Proposed changes

  • Makes M1Grey solutions option creatable to be consistent with other code

Upgrade instructions

  • New AnalyticSolutions for M1Grey should be added to RadiationTransport::M1Grey::Solutions::all_solutions
  • Executable was renamed to EvolveM1Grey
  • Input file needs updating (see tests/InputFiles/RadiationTransport/M1Grey/ConstantM1.yaml)

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe merged commit 21524b5 into sxs-collaboration:develop Nov 15, 2024
22 of 23 checks passed
@kidder kidder deleted the m1grey_runtime_id branch December 10, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants